-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Drop Black as formater from the lint environment in ddev #20451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
76c1c45
to
2e6e400
Compare
The changelog type |
2e6e400
to
1085961
Compare
The changelog type |
The changelog type |
1085961
to
c5defd7
Compare
The changelog type |
c5defd7
to
cb7923e
Compare
The changelog type |
The changelog type |
cb7923e
to
73c496a
Compare
The changelog type |
73c496a
to
d9c7f24
Compare
The changelog type |
d9c7f24
to
38b8853
Compare
The changelog type |
38b8853
to
962481f
Compare
962481f
to
a3a8e0d
Compare
|
What does this PR do?
This PR removes the black dependency in the environment collector to allow
Motivation
For some reason we are not using ruff to format and just to lint our code. However, when running in an IDE developers might be using ruff to format on save which is efficient and can be configure in the same way as black. However, quotes follow by default PEP guidelines using double quotes which means that by formatting with ruff from the IDE (like VSCode) string quotes can be modified by mistake.
The current black configuration includes ignoring string quotes but the ruff configuration does not. This PR updates it.
The pydantic version change is done to be in line with the base package.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged