-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for mlx5_core drivers in ethtool integration [CMPT-3460] #20481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2c2e569
to
3474d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @41ks, thanks for the PR!
Just one comment - we keep track of which metrics are emitted by an integration in metadata.csv. The file also includes other information about the metrics such as a description and the unit of measure. Could you update it with the new metrics? Let me know if you have any question!
3474d19
to
6a33817
Compare
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
alex.melhem@datadoghq.com unqueued this merge request |
/remove |
View all feedbacks in Devflow UI.
|
What does this PR do?
This PR adds support for mlx5_core drivers in the network integration.
It does so by adding the metrics of interest in the const.py file.
Some logic was also added to allow for parsing of queue numbers on this type of interface.
Motivation
This PR enhances monitoring for interfaces using mlx5 drivers, such as those found in Azure VMs.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged