Skip to content

Add support for mlx5_core drivers in ethtool integration [CMPT-3460] #20481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into from

Conversation

41ks
Copy link

@41ks 41ks commented Jun 11, 2025

What does this PR do?

This PR adds support for mlx5_core drivers in the network integration.

It does so by adding the metrics of interest in the const.py file.

Some logic was also added to allow for parsing of queue numbers on this type of interface.

Motivation

This PR enhances monitoring for interfaces using mlx5 drivers, such as those found in Azure VMs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (3a65eb4) to head (6a33817).
Report is 13 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
network 94.07% <100.00%> (+0.17%) ⬆️
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@41ks 41ks force-pushed the alex.melhem/support-mlx5-interfaces branch 2 times, most recently from 2c2e569 to 3474d19 Compare June 11, 2025 12:52
@41ks 41ks marked this pull request as ready for review June 11, 2025 15:25
@41ks 41ks requested review from a team as code owners June 11, 2025 15:25
@DataDog DataDog deleted a comment from github-actions bot Jun 16, 2025
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @41ks, thanks for the PR!

Just one comment - we keep track of which metrics are emitted by an integration in metadata.csv. The file also includes other information about the metrics such as a description and the unit of measure. Could you update it with the new metrics? Let me know if you have any question!

@41ks 41ks force-pushed the alex.melhem/support-mlx5-interfaces branch from 3474d19 to 6a33817 Compare June 17, 2025 13:21
@41ks 41ks requested a review from nubtron June 17, 2025 13:27
@41ks
Copy link
Author

41ks commented Jun 18, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 18, 2025

View all feedbacks in Devflow UI.

2025-06-18 10:51:41 UTC ℹ️ Start processing command /merge


2025-06-18 10:51:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-06-18 11:04:26 UTC ⚠️ MergeQueue: This merge request was unqueued

alex.melhem@datadoghq.com unqueued this merge request

@41ks
Copy link
Author

41ks commented Jun 18, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jun 18, 2025

View all feedbacks in Devflow UI.

2025-06-18 11:04:20 UTC ℹ️ Start processing command /remove


2025-06-18 11:04:23 UTC ℹ️ Devflow: /remove

@41ks 41ks added this pull request to the merge queue Jun 18, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants