Skip to content

Don't check external psycopg packages for openssl3 copies #20513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jun 13, 2025

What does this PR do?

It adds a mechanism to bypass the "don't include externally built openssl3" checks.

Motivation

This will let us update from psycopg2 to psycopg(3) without having to build it ourselves (at the expense of shipping different openssl3 versions). psycopg2 got off the hook so far because it ships openssl 1, not 3.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@alopezz alopezz force-pushed the alopez/allow-openssl3-from-psycopg branch from 31eb34b to b42b18a Compare June 17, 2025 12:25
@alopezz alopezz force-pushed the alopez/allow-openssl3-from-psycopg branch from b42b18a to e1639a9 Compare June 17, 2025 12:46
@alopezz alopezz marked this pull request as ready for review June 17, 2025 14:34
@alopezz alopezz requested a review from a team as a code owner June 17, 2025 14:34
rdesgroppes
rdesgroppes previously approved these changes Jun 17, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed rdesgroppes’s stale review June 17, 2025 16:09

Review from rdesgroppes is dismissed. Related teams and files:

  • agent-build
    • .builders/scripts/repair_wheels.py
@alopezz alopezz requested a review from rdesgroppes June 18, 2025 07:49
Copy link

@rdesgroppes rdesgroppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alopezz alopezz added this pull request to the merge queue Jun 18, 2025
Merged via the queue into master with commit dab0c22 Jun 18, 2025
33 checks passed
@alopezz alopezz deleted the alopez/allow-openssl3-from-psycopg branch June 18, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants