Fix correct tag values for MySQL Percona Server #20529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix most tests for percona fix final test
dujuku
added
qa/skip-qa
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dujuku
commented
Jun 17, 2025
Comment on lines
+35
to
+41
| actual_payload["tables"].sort(key=lambda x: x["name"]) | ||
| for table in actual_payload['tables']: | ||
| table['create_time'] = "normalized_value" | ||
| if 'columns' in table: | ||
| table['columns'].sort(key=lambda x: x['name']) | ||
| if 'indexes' in table: | ||
| table['indexes'].sort(key=lambda x: x['name']) |
There was a problem hiding this comment.
Adding the sorting here due to flaky tests. I think the only time ordering will matter is in the case of columns, but they have an ordinal_position field, so deterministic ordering in the payload should be unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support and test scaffolding for Percona Server. This is an initial foundation to make further changes on, but there is a public change in the new query for the
@@version_commentvariable which is used to indicate whether the server is running a Percona build. This will be visible in tags.Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged