Add a second call to ReadFriendsList() #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observe that after the second call the GetFriends() won't return the list of friends.
The bug is here in the
FUserManagerEOS::AddFriend()
function:The
UniqueNetIdToAttributeAccessMap
basically contains the cached information of friends which is populated during the first call to theReadFriendsList()
.During the second call, here we skip calling the
AddRemotePlayer()
function to avoid making unnecessary requests for obtainig the friends info which we already have in our cache.However the problem is that we've forgotten to set the friend info using our cached values in the else block. The fix would be to move a piece of code from the
FUserManagerEOS::ReadUserInfo()
to here: