Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

Commit 88d82e1

Browse files
Merge pull request #492 from mcottontensor/setting_option_fix
Setting option fix
2 parents 672397e + caddb00 commit 88d82e1

File tree

3 files changed

+45
-3
lines changed

3 files changed

+45
-3
lines changed
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
name: Run signalling tests
2+
3+
on:
4+
workflow_dispatch:
5+
push:
6+
branches: ['signalling_tester']
7+
paths: ['SignallingWebServer/**']
8+
pull_request:
9+
branches: ['signalling_tester']
10+
paths: ['SS_Test/**']
11+
12+
jobs:
13+
14+
build:
15+
runs-on: ubuntu-latest
16+
defaults:
17+
run:
18+
working-directory: ./
19+
20+
permissions:
21+
contents: write
22+
23+
steps:
24+
- name: "Checkout source code"
25+
uses: actions/checkout@v3
26+
27+
- uses: actions/setup-node@v3
28+
with:
29+
node-version: '18.x'
30+
registry-url: 'https://registry.npmjs.org'
31+
32+
- name: Run signalling server
33+
working-directory: ./SignallingWebServer
34+
run: ./platform_scripts/bash/run_local.sh &
35+
36+
- name: Install library deps
37+
working-directory: ./SS_Test
38+
run: npm ci
39+
40+
- name: Run frontend lib tests
41+
working-directory: ./SS_Test
42+
run: npm run start

Frontend/library/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Frontend/library/src/Config/SettingOption.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class SettingOption<
2424
// eslint-disable-next-line @typescript-eslint/no-empty-function
2525
defaultOnChangeListener: (changedValue: unknown, setting: SettingBase) => void = () => { /* Do nothing, to be overridden. */ }
2626
) {
27-
super(id, label, description, [defaultTextValue], defaultOnChangeListener);
27+
super(id, label, description, defaultTextValue, defaultOnChangeListener);
2828

2929
this.options = options;
3030
const urlParams = new URLSearchParams(window.location.search);

0 commit comments

Comments
 (0)