Calculator: Support hex numbers

[TBM13]

Allows hex numbers like 0x4F to be used in the calculator plugin.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The regular expression used for validating calculator expressions was updated to support hexadecimal number literals in addition to the previously allowed tokens. No changes were made to logic or control flow, and no public or exported entity declarations were altered.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Calculator/Main.cs	Updated regex pattern to allow hexadecimal number literals.

Suggested labels

enhancement

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Plugins/Flow.Launcher.Plugin.Calculator/Main.cs (1)

23-23: Consider supporting uppercase hex prefix and verify Mages engine compatibility.

The hex pattern addition looks good, but there are two potential concerns:

1. The pattern only supports lowercase 0x prefix but not uppercase 0X. Users might expect both formats to work.
2. Need to verify that the underlying Mages engine actually supports hex literal interpretation.

Consider updating the pattern to support both cases:

-@"[ei]|[0-9]|0x[\da-fA-F]+|[\+\%\-\*\/\^\., ""]|[\(\)\|\!\[\]]" +
+@"[ei]|[0-9]|0[xX][\da-fA-F]+|[\+\%\-\*\/\^\., ""]|[\(\)\|\!\[\]]" +

Run the following script to verify Mages engine hex support:

#!/bin/bash
# Description: Check if Mages engine supports hexadecimal literals
# Expected: Find documentation or examples of hex support in Mages

# Search for Mages documentation or source code mentioning hex support
rg -i "hex|0x" --type cs -A 3 -B 3

# Look for any existing tests that might use hex numbers
fd -e cs -x rg -l "0x" {}

# Check NuGet package documentation if available
echo "Please also search the web for Mages engine hex literal support"

Additionally, please search the web for Mages engine hex literal support:

Does the Mages mathematical expression engine support hexadecimal number literals like 0x4F?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40e5c04 and d68964b.

📒 Files selected for processing (1)

• Plugins/Flow.Launcher.Plugin.Calculator/Main.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Report (PR)
• GitHub Check: gitStream.cm

[Jack251970]

LGTM! Thanks for your contribution!