-
Notifications
You must be signed in to change notification settings - Fork 277
test(ui5-time-picker): migrate tests to cypress #11732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6544603
test(ui5-time-picker): migrate tests to cypress
hinzzx 10b7798
chore: address comments
hinzzx 184a99b
test: address comments
hinzzx 8bf38e6
chore: correct test types
hinzzx c68cdf3
test: address comments
hinzzx 72ede2e
Merge branch 'main' into tp-tests-migration
hinzzx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,390 @@ | ||
import "../../src/Assets.js"; | ||
import { setLanguage } from "@ui5/webcomponents-base/dist/config/Language.js"; | ||
import TimePicker from "../../src/TimePicker.js"; | ||
import Label from "../../src/Label.js"; | ||
|
||
describe("TimePicker Tests", () => { | ||
it("input receives value in format pattern depending on the set language", () => { | ||
cy.wrap({ setLanguage }) | ||
.invoke("setLanguage", "bg"); | ||
|
||
cy.mount(<TimePicker value="03:16:16"></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "3:16:16 ч."); | ||
|
||
cy.wrap({ setLanguage }) | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.invoke("setLanguage", "en"); | ||
}); | ||
|
||
it("tests clocks value", () => { | ||
cy.mount(<TimePicker formatPattern="HH:mm:ss" value="11:12:13"></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetClock("hours") | ||
.should("have.prop", "selectedValue", 11); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetClock("minutes") | ||
.should("have.prop", "selectedValue", 12); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetClock("seconds") | ||
.should("have.prop", "selectedValue", 13); | ||
}); | ||
|
||
it("tests clocks submit value", () => { | ||
cy.mount(<TimePicker formatPattern="hh:mm:ss" value="12:00:01"></TimePicker>); | ||
|
||
function pressKeyNTimes(key: "ArrowDown" | "ArrowUp" | "Space" | "Tab" | "Enter", n: number) { | ||
for (let i = 0; i < n; i++) { | ||
cy.realPress(key); | ||
} | ||
} | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetClock("hours") | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.realClick(); | ||
|
||
pressKeyNTimes("ArrowDown", 10); | ||
cy.realPress("Space"); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetClock("minutes"); | ||
|
||
pressKeyNTimes("ArrowDown", 22); | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pressKeyNTimes("ArrowUp", 2); | ||
|
||
cy.realPress("Space"); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetClock("seconds"); | ||
|
||
pressKeyNTimes("ArrowUp", 4); | ||
|
||
cy.realPress("Tab"); | ||
cy.realPress("Enter"); | ||
|
||
cy.get("@timePicker") | ||
.should("have.value", "02:40:05"); | ||
}); | ||
|
||
it("tests submit wrong value", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realType("123123123") | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.realPress("Enter"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.shadow() | ||
.find("ui5-datetime-input") | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.should("have.attr", "value-state", "Negative"); | ||
}); | ||
|
||
it("tests change event", () => { | ||
cy.mount(<TimePicker formatPattern="HH:mm" value="12:00"></TimePicker>); | ||
|
||
const changeStub = cy.stub().as("changeStub"); | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.then($el => { | ||
$el[0].addEventListener("ui5-change", changeStub); | ||
}); | ||
|
||
// Open picker and submit without changes | ||
cy.get("@timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetSubmitButton() | ||
.realClick(); | ||
|
||
// Assert no change event was fired | ||
cy.get("@changeStub").should("not.have.been.called"); | ||
|
||
// Open picker, change time and submit | ||
cy.get("@timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetClock("hours") | ||
.realClick() | ||
.realPress("PageDown") // select 11 | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("ArrowDown") | ||
.realPress("Space"); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetSubmitButton() | ||
.realClick(); | ||
|
||
// Assert change event was fired once | ||
cy.get("@changeStub").should("have.been.calledOnce"); | ||
|
||
// Open picker and submit without changes | ||
cy.get("@timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetSubmitButton() | ||
.realClick(); | ||
|
||
// Assert change event was not fired again | ||
cy.get("@changeStub").should("have.been.calledOnce"); | ||
|
||
// Open picker, change time and submit | ||
cy.get("@timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetClock("hours") | ||
.realClick() | ||
.realPress("ArrowDown") // select 00 | ||
.realPress("Space"); | ||
|
||
cy.get("@timePicker") | ||
.ui5TimePickerGetSubmitButton() | ||
.realClick(); | ||
|
||
// Assert change event was fired again | ||
cy.get("@changeStub").should("have.been.calledTwice"); | ||
|
||
// Test direct input change | ||
cy.get("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress("Backspace") | ||
.realType("7") | ||
.realPress("Enter"); | ||
|
||
// Assert change event was fired again | ||
cy.get("@changeStub").should("have.been.calledThrice"); | ||
}); | ||
|
||
it("tests value state", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick(); | ||
|
||
// Clear the input | ||
cy.get<TimePicker>("@timePicker") | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.ui5TimePickerGetInnerInput() | ||
.clear(); | ||
|
||
cy.get("body").realClick(); // Click outside to trigger blur | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.shadow() | ||
.find("ui5-datetime-input") | ||
.should("have.attr", "value-state", "None"); | ||
}); | ||
|
||
it("tests input keyboard handling", () => { | ||
cy.mount(<TimePicker formatPattern="hh:mm:ss" value="02:40:05"></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress(["Shift", "PageUp"]); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "02:41:05"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress(["Shift", "PageDown"]); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "02:40:05"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress("PageUp"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "03:40:05"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress("PageDown"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "02:40:05"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress(["Shift", "Control", "PageUp"]); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "02:40:06"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress(["Shift", "Control", "PageDown"]); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.value", "02:40:05"); | ||
}); | ||
|
||
it("test closing the picker with the keyboard", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.realPress(["Alt", "ArrowUp"]); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.should("not.have.attr", "open"); | ||
}); | ||
|
||
it("the value 'now' returns the current time, instead of the string 'now'", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realType("now") | ||
.realPress("Enter"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.should("not.have.value", "now"); | ||
}); | ||
|
||
it("opening time picker's value-help, sets the 'open' property to true", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.should("have.attr", "open"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.shadow() | ||
.find("ui5-responsive-popover") | ||
.should("have.attr", "open"); | ||
}); | ||
|
||
it("setting time picker's open property to true, opens the value-help", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.then($el => { | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$el.prop("open", true); | ||
}); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.shadow() | ||
hinzzx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.find("ui5-responsive-popover") | ||
.should("have.attr", "open"); | ||
}); | ||
|
||
it("picker popover should have accessible name", () => { | ||
cy.mount(<TimePicker></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerGetInnerInput() | ||
.realClick() | ||
.should("be.focused") | ||
.realPress("F4"); | ||
|
||
cy.get<TimePicker>("@timePicker") | ||
.shadow() | ||
.find("ui5-responsive-popover") | ||
.should("have.attr", "accessible-name", "Choose Time"); | ||
}); | ||
|
||
it("input should have accessible name", () => { | ||
cy.mount( | ||
<> | ||
<Label id="timeLabel">Pick a time</Label> | ||
<TimePicker accessibleNameRef="timeLabel"></TimePicker> | ||
</> | ||
); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.attr", "aria-label", "Pick a time"); | ||
}); | ||
|
||
it("should apply aria-label from the accessibleName property", () => { | ||
cy.mount(<TimePicker accessibleName="Pick a time"></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.ui5TimePickerGetInnerInput() | ||
.should("have.attr", "aria-label", "Pick a time"); | ||
}); | ||
|
||
it("displays value state message header in popover when value state is set", () => { | ||
cy.mount(<TimePicker valueState="Negative"></TimePicker>); | ||
|
||
cy.get("[ui5-time-picker]") | ||
.as("timePicker") | ||
.ui5TimePickerValueHelpIconPress(); | ||
|
||
cy.get("@timePicker") | ||
.shadow() | ||
.find("ui5-responsive-popover") | ||
.find(".ui5-valuestatemessage-header") | ||
.should("exist") | ||
.and("have.class", "ui5-valuestatemessage--error"); | ||
}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.