-
Notifications
You must be signed in to change notification settings - Fork 277
chore(ui5-tab-container): migrate tests to Cypress #11737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
migrates tab container tests to Cypress JIRA: BGSOFUIRODOPI-3462
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete the old .spec file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 test failings:
- tests if content is scrollable when tab-container takes limited height by its parent
error: assert expected 299.9884338378906 to be at least 300 - test sub items selection
error: Timed out retrying after 4050ms: cy.click() failed because this element is not visible:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of warnings in the console for attributes usages. Replace them with properties in order to benefit from type checking
Address review comments
migrates tab container tests to Cypress
JIRA: BGSOFUIRODOPI-3462