feat(cli): add expo framework support to bundle command #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydkim
reviewed
Jun 17, 2025
cli/commands/bundleCommand/index.js
Outdated
| @@ -4,13 +4,15 @@ const { OUTPUT_BUNDLE_DIR, ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../consta | |||
|
|
|||
| program.command('bundle') | |||
| .description('Creates a CodePush bundle file (assumes Hermes is enabled).') | |||
| .addOption(new Option('-t, --type <type>', 'project type (react-native | expo)').choices(['react-native', 'expo']).default('react-native')) | |||
There was a problem hiding this comment.
How about changing the name of option to -f, --framework and running the expo bundle command only when -f expo option passed?
Because I thought framework represents Expo’s identity better than type.
(I also considered using a --expo flag, but it didn’t seem scalable for future frameworks. 😆 )
There was a problem hiding this comment.
@floydkim
Awesome! Just switched type to framework as you suggested.
I've also updated the PR description and the README to reflect these changes.
saseungmin
changed the title
floydkim
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
@saseungmin Thank you!
This diff may be released as v9.2.0 along with your expo-plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Overview
Adds Expo project support to the code-push CLI, enabling CodePush functionality for Expo projects alongside existing React Native projects.
✨ What's Added
-f, --frameworkparameter with choicesexpo(only expo)runExpoBundleCommandfunction usingexpo export:embedbundleandreleasecommands now support both project types🔧 Changes Made
1. Enhanced CLI Commands
Bundle Command (
cli/commands/bundleCommand/index.js)--frameworkoption withexpochoicesreact-nativefor backward compatibilityRelease Command (
cli/commands/releaseCommand/index.js)--frameworkoption support2. Core Bundle Logic (
cli/commands/bundleCommand/bundleCodePush.js)frameworkparameter tobundleCodePushfunctionreact-native(default): Uses existingrunReactNativeBundleCommandexpo: Uses newrunExpoBundleCommand3. New Expo Bundle Function (
cli/functions/runExpoBundleCommand.js)expo export:embed4. Release Pipeline Updates (
cli/commands/releaseCommand/release.js)releasefunction to accept and pass throughtypeparameter5. Documentation Updates (
README.md)--frameworkparameter bundle, release cli description🎯 Usage Examples
For React Native Projects (unchanged)
For Expo Projects (new)
✅ Testing
expo export:embed🔄 Breaking Changes
None - This is a fully backward compatible addition. All existing commands continue to work exactly as before.
📋 Related Work