[FLINK-37921][table] Replace TableKeyedAsyncWaitOperator with new operator under new async framework #26698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xishuaidelin
force-pushed
the
refactor-pr
branch
3 times, most recently
from
cbb45a6 to
abaedef
Compare
|
@xishuaidelin We need to split non table related changes into separate commit. |
xishuaidelin
force-pushed
the
refactor-pr
branch
from
abaedef to
a858277
Compare
Zakelly
reviewed
Jun 20, 2025
| return resultHandler; | ||
| } | ||
|
|
||
| public void waitAllInFlightInputsFinished() { |
There was a problem hiding this comment.
maybe asyncExecutionController.drainInflightRecords(0); is enough. I'd suggest not using waitUntil since it mainly used for waiting specified requests.
| // which would trigger dispose the context in AsyncExecutionController | ||
| // This part is executed in the AsyncExecutor | ||
| () -> { | ||
| KeyedResultHandler handler = invoke(element); |
There was a problem hiding this comment.
Ahhh..... I don't think this is the best practice.
I'd suggest the invoke produce a AsyncFuture, by wrapping one and providing to asyncFunction. And do thenXxxx on the future here to chain the following action. The AEC will track all the chaining operation and keep it run in main thread. We'd better not do something like KeyedResultHandler.processInMailbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Current key ordered lookup join implementation borrows most concepts of FLIP-425 like Epoch, AsynExecutionController, etc. This leads to much code duplication. This pr aims to integrate current implementation into async processing framework which introduced in FLINK-37930. This pr is to replace the implementation in FLINK-37877 while the TableAsyncExecutionController would be removed later.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
AsyncKeyOrderedLookupOperatorTest is added to verify this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no )Documentation