-
Notifications
You must be signed in to change notification settings - Fork 263
Add support for catalog federation in the CLI #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lateness. Overall LGTM! All related properties in the spec seem to have a correct correspondence in the argument list.
--catalog-role-session-name (For authentication type SIGV4) The role session name to be used by the SigV4 protocol for signing requests | ||
--catalog-external-id (For authentication type SIGV4) An optional external id used to establish a trust relationship with AWS in the trust policy | ||
--catalog-signing-region (For authentication type SIGV4) Region to be used by the SigV4 protocol for signing requests | ||
--catalog-signing-name (For authentication type SIGV4) The service name to be used by the SigV4 protocol for signing requests, the default signing name is "execute-api" is if not provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Non-blocker] I think it will be good to provide some example of creating an external "Iceberg_rest"/"hadoop" catalog with various auth types, may be in a follow-up
The CLI currently only supports the version of EXTERNAL catalogs that was present in 0.9.0. Now, EXTERNAL catalogs can be configured with various configurations relating to federation. This PR updates the CLI to better match the REST API so that federated catalogs can be easily set up in the CLI.