-
Notifications
You must be signed in to change notification settings - Fork 268
test(integration): refactor PolarisRestCatalogIntegrationTest to run against any cloud provider #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring, @HotSushi ! Thanks for your contribution.
Some minor comments below.
Also, would you mind adding a small note for how to run these tests with various storage providers in a README under the integration-tests
module?
Edit: README somewhere... integration-tests
is not aware of cloud providers, of course 😅
...rc/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogAwsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogAwsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from AWS test failures, the changes LGTM.
Would anyone be able to validate Azure and GCS tests?
@dimas-b tested and working on all clouds, should be good to merge? Need another approval~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @HotSushi ! ... merging.
Summary
This PR makes it easier to test the Polaris catalog across different cloud environments by refactoring the existing integration tests -
PolarisRestCatalogIntegrationTest
. Previously, the tests would only run for S3 or local storage. Key changes include:Changes are influenced by the PR: https://github.com/apache/polaris/pull/590/files#diff-725b3a0c77d412c1d2b2b3cc1660824f180bfc459b7180023b6c26ba6d4e0962
Testing
✅
./gradlew build
succeeds✅
./gradlew check
succeeds✅ AWS Test succeeds:
✅ AZURE Test succeeds:
✅ GCP Test succeeds: