[SPARK-52363][SQL][TESTS] Analyzer NameScope test for nested struct fields inside map values #51059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inside Map values
|
@vladimirg-db Hello, when I was reading the new Analyzer code, I found we didn't use |
vladimirg-db
approved these changes
May 31, 2025
|
Thanks @vladimirg-db , I found that we also lack tests for some new analyzer components such as |
|
These components are relatively trivial. We rely on analyzed plan golden files for them: #50568 |
HyukjinKwon
approved these changes
Jun 1, 2025
HyukjinKwon
changed the title
|
Merged to master. |
Thanks for the explanation @vladimirg-db |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…ields inside map values ### What changes were proposed in this pull request? This PR adds test coverage for resolving nested struct fields inside Map values which was missing in the original test suite. ### Why are the changes needed? The new test verifies that multi-part resolution like mapColumn['key'].nestedField works correctly, we already defined a field `col11MapWithStruct`, but we didn't test it properly. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unneeded ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51059 from dengziming/SPARK-52363. Authored-by: dengziming <dengziming@bytedance.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds test coverage for resolving nested struct fields inside Map values which was missing in the original test suite.
Why are the changes needed?
The new test verifies that multi-part resolution like mapColumn['key'].nestedField works correctly, we already defined a field
col11MapWithStruct, but we didn't test it properly.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unneeded
Was this patch authored or co-authored using generative AI tooling?
No