Use strings for provides/requires #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentryMan
force-pushed
the
string-spi
branch
2 times, most recently
from
2944168 to
80ef6c5
Compare
this prevents issues where auto provided/required types not available during compilation or plugin activation fail builds
Revert "Update AvajeModule.java" This reverts commit 87b41c2. Update AvajeModule.java
there is no reason to split into three separate methods
rbygrave
reviewed
Jul 14, 2025
| if (!requires.isEmpty()) { | ||
| attributeClasses(leadingComma, writer, "requires", requires); | ||
| if (!genericProvides.isEmpty()) { | ||
| attributeString(false, writer, "providesString", provides); |
There was a problem hiding this comment.
this doesn't look correct. Looks like provides is incorrectly used instead of genericProvides.
similarly, line 408 looks incorrect.
rbygrave
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents issues where auto-provided/required types are not available during compilation or plugin activation.
@InjectModuleprovides/requires (via string provides/requires)resolves #834