Python 2/3 compatibility and make able to standalone install inside virtualenv #10
Conversation
…em while installing this product in virtualenv because of cryptography and asn1crypto dependencies. * python2/3 compatiblity added in encrypt module * pipenv introduced for development for easy package management * tests are made pass due to recent changes
…bject,Bcc,Cc those are included into smime message
* say hello to pytest implementation * travis file added * manifest and Changes rst file added
trevis file updated
|
Hi, I've seen your changes now, sorry the delay. I understand all you did, but as Python 2 support is ending its life in January 1st, 2020, I don't think this effort will worth it. Let me know if you have a different opinion. The case is that many changes have been made, I'm looking for just little and direct changes over the original code, as developing several different unit tests covering everything is particularly time-consuming, and I have no time to do that. |
|
Hi, @balena thanks for your reply, Another thing, do you have any plan to support S/MIME signed and encrypted messages? |
Background
First I was facing problem install this package inside my project under virtual environment (
cryptographyandasn1cryptoare not installed globally). I know the reason (kind of egg, hen problem): in the setup.py file you made install_requires for those packages, that's fine and also version is coming from smime/init.py that's good but in that file you also import .encrypt.encrypt as a result during installing this product by pip/easy_install, getting import error.I understand that problem can be solved by globally install or install those inside virtualenv first but I think those options are not that good idea
What I Changes