fix: expose missing NATIVEWIND_OS in NativeWind plugin
#1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a73b14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbroma
requested changes
Jun 16, 2025
There was a problem hiding this comment.
hi @raghav-reglobe 👋 thanks for the PR!
left some comments 👇
**Commit message:** Set `process.env.NATIVEWIND_OS` based on `compiler.options.name` if it is "android" or "ios" in NativeWind plugin - Removes `presetPlatform` option and related logic. - Automatically sets `process.env.NATIVEWIND_OS` to "android" or "ios" if `compiler.options.name` matches. - Ensures consistent platform detection for NativeWind builds.
Removed unused commit.
jbroma
approved these changes
Jun 16, 2025
|
@raghav-reglobe please also run |
jbroma
reviewed
Jun 17, 2025
jbroma
approved these changes
Jun 17, 2025
jbroma
changed the title
NATIVEWIND_OS in NativeWind plugin.
jbroma
changed the title
NATIVEWIND_OS in NativeWind plugin.NATIVEWIND_OS in NativeWind plugin
|
@raghav-reglobe thank you for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
nativewind/preset chooses web, when process.env.NATIVEWIND_OS !== "native" or is undefined.
The Re-Pack plug-in never sets that variable, so Tailwind’s web defaults win and the angle variables
(--tw-rotate, --tw-skew-x/y) are emitted as bare 0 → Android crashes.
Metro does set the var (via withNativeWind()), so the two bundlers behave differently.
Proposed fix
Force the platform passed to nativewind/preset.
Why this solves the root bug (no work-arounds)
--tw-rotate: 0deg; --tw-skew-x:0deg; --tw-skew-y:0degto the reset layer,so the generated CSS already has the correct units.
cssToReactNativeRuntimeoutput,and palette colours work unchanged.