*: consolidate InternalClient RPC client creation
#148607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cthumuluru-crdb
changed the title
InternalClient RPC client creation
cthumuluru-crdb
force-pushed
the
drpc-peer-pr1
branch
from
f989a9d to
ac09e1e
Compare
tbg
approved these changes
Jun 23, 2025
| "github.com/cockroachdb/cockroach/pkg/server" | ||
| "github.com/cockroachdb/cockroach/pkg/server/serverpb" | ||
| "github.com/cockroachdb/cockroach/pkg/ts/tspb" | ||
| "github.com/cockroachdb/errors" | ||
| "google.golang.org/grpc" | ||
| "storj.io/drpc" |
This commit consolidates `InternalClient` RPC client creation logic and replaces RPC clients with adapters. It is a continuation of the work done in cockroachdb#147606. Epic: CRDB-48923 Fixes: cockroachdb#148353 Release note: none
cthumuluru-crdb
force-pushed
the
drpc-peer-pr1
branch
from
ac09e1e to
8279a65
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consolidates
InternalClientRPC client creation logic and replaces RPC clients with adapters. It is a continuation of the work done in #147606.Epic: CRDB-48923
Fixes: #148353
Release note: none