Skip to content

*: add DRPC dial methods to nodedialer #148610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

cthumuluru-crdb
Copy link
Contributor

@cthumuluru-crdb cthumuluru-crdb commented Jun 20, 2025

This change enables nodedialer to dial either a gRPC or a DRPC connection, depending on rpc.experimental_drpc.enabled setting.

Epic: CRDB-48923
Fixes: none
Release note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cthumuluru-crdb cthumuluru-crdb added the do-not-merge bors won't merge a PR with this label. label Jun 23, 2025
@cthumuluru-crdb cthumuluru-crdb force-pushed the drpc-peer-pr3 branch 2 times, most recently from 3a91333 to 878108e Compare June 24, 2025 15:20
@cthumuluru-crdb cthumuluru-crdb marked this pull request as ready for review June 24, 2025 15:53
@cthumuluru-crdb cthumuluru-crdb requested review from a team as code owners June 24, 2025 15:53
@cthumuluru-crdb cthumuluru-crdb requested review from dhartunian and shubhamdhama and removed request for a team June 24, 2025 15:53
This change enables nodedialer to dial either a gRPC or a DRPC connection,
depending on `rpc.experimental_drpc.enabled` setting.

Epic: CRDB-48923
Fixes: none
Release note: none
@cthumuluru-crdb cthumuluru-crdb removed the do-not-merge bors won't merge a PR with this label. label Jun 25, 2025
@cthumuluru-crdb
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 25, 2025

@craig craig bot merged commit b0b5d89 into cockroachdb:master Jun 25, 2025
22 checks passed
@cthumuluru-crdb cthumuluru-crdb deleted the drpc-peer-pr3 branch June 25, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants