-
Notifications
You must be signed in to change notification settings - Fork 3.9k
*: create DRPC RPC clients conditionally #148611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+227
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
35181cf
to
66d74fc
Compare
shubhamdhama
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tbg
approved these changes
Jun 25, 2025
1e78f69
to
7443f56
Compare
Create DRPC RPC clients when DRPC is enabled. Although DRPC is currently disabled by default, it will be eventually controlled via `rpc.experimental_drpc.enabled` cluster setting. Epic: CRDB-48923 Fixes: none Release note: none
7443f56
to
9af31f0
Compare
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
148611: *: create DRPC RPC clients conditionally r=cthumuluru-crdb a=cthumuluru-crdb Create DRPC RPC clients when DRPC is enabled. Although DRPC is currently disabled by default, it will be eventually controlled via `rpc.experimental_drpc.enabled` cluster setting. Epic: CRDB-48923 Fixes: none Release note: none 148796: workflows: run update_releases on release-25.3 r=jlinder a=rail Release note: none Epic: none Co-authored-by: Chandra Thumuluru <chandra.thumuluru@cockroachlabs.com> Co-authored-by: Rail Aliiev <rail@iqchoice.com>
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create DRPC RPC clients when DRPC is enabled. Although DRPC is currently disabled by default, it will be eventually controlled via
rpc.experimental_drpc.enabled
cluster setting.Epic: CRDB-48923
Fixes: none
Release note: none