Skip to content

*: create DRPC RPC clients conditionally #148611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

cthumuluru-crdb
Copy link
Contributor

@cthumuluru-crdb cthumuluru-crdb commented Jun 20, 2025

Create DRPC RPC clients when DRPC is enabled. Although DRPC is currently disabled by default, it will be eventually controlled via rpc.experimental_drpc.enabled cluster setting.

Epic: CRDB-48923
Fixes: none
Release note: none

Copy link

blathers-crl bot commented Jun 20, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cthumuluru-crdb cthumuluru-crdb force-pushed the drpc-peer-pr4 branch 3 times, most recently from 35181cf to 66d74fc Compare June 25, 2025 08:48
@cthumuluru-crdb cthumuluru-crdb marked this pull request as ready for review June 25, 2025 08:51
@cthumuluru-crdb cthumuluru-crdb requested review from a team as code owners June 25, 2025 08:51
@cthumuluru-crdb cthumuluru-crdb requested review from tbg, shubhamdhama, a team, herkolategan, DarrylWong and mw5h and removed request for DrewKimball and a team June 25, 2025 08:51
Copy link
Contributor

@shubhamdhama shubhamdhama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cthumuluru-crdb cthumuluru-crdb requested a review from a team as a code owner June 25, 2025 15:12
Create DRPC RPC clients when DRPC is enabled. Although DRPC is
currently disabled by default, it will be eventually controlled
via `rpc.experimental_drpc.enabled` cluster setting.

Epic: CRDB-48923
Fixes: none
Release note: none
@cthumuluru-crdb
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jun 25, 2025
148611: *: create DRPC RPC clients conditionally r=cthumuluru-crdb a=cthumuluru-crdb

Create DRPC RPC clients when DRPC is enabled. Although DRPC is currently disabled by default, it will be eventually controlled via `rpc.experimental_drpc.enabled` cluster setting.

Epic: CRDB-48923
Fixes: none
Release note: none

148796: workflows: run update_releases on release-25.3 r=jlinder a=rail

Release note: none
Epic: none

Co-authored-by: Chandra Thumuluru <chandra.thumuluru@cockroachlabs.com>
Co-authored-by: Rail Aliiev <rail@iqchoice.com>
@craig
Copy link
Contributor

craig bot commented Jun 25, 2025

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 25, 2025

@craig craig bot merged commit 758f3aa into cockroachdb:master Jun 25, 2025
22 checks passed
@cthumuluru-crdb cthumuluru-crdb deleted the drpc-peer-pr4 branch June 25, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants