changefeedccl: fix job progress checkpoint fields invariant violation #148617
+81
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
This patch modifies the changefeed job progress saving code so that we only create a string for a span-level checkpoint when we actually need it for logging. Release note: None
andyyang890
force-pushed
the
20250620-fix-checkpoint-assertion
branch
from
adf3f9b to
cae11ca
Compare
andyyang890
added
the
backport-25.2.x
andyyang890
requested review from
jeffswenson,
KeithCh and
asg0451
and removed request for
a team
andyyang890
force-pushed
the
20250620-fix-checkpoint-assertion
branch
4 times, most recently
from
c2eec46 to
5bc352e
Compare
Release note (bug fix): A bug where a changefeed that was created before v25.2 could fail after upgrading to v25.2 with the error message `both legacy and current checkpoint set on change aggregator spec` has now been fixed.
andyyang890
force-pushed
the
20250620-fix-checkpoint-assertion
branch
from
5bc352e to
db4ca24
Compare
|
TeamCity run with 20 successful runs of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148560
Fixes #148620
changefeedccl: avoid creating checkpoint string all the time
This patch modifies the changefeed job progress saving code so that
we only create a string for a span-level checkpoint when we actually
need it for logging.
Release note: None
changefeedccl: fix job progress checkpoint fields invariant violation
Release note (bug fix): A bug where a changefeed that was created before
v25.2 could fail after upgrading to v25.2 with the error message
both legacy and current checkpoint set on change aggregator spechas now been fixed.