storage: disable short attribute extractor in temp engine #148631
Merged
+19
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the short attribute extractor in temporary engines. The short attribute extractor is only capable of parsing Cockroach MVCC keys. Additionally, rename some temp engine identifiers that needlessly were prefixed with 'Pebble'. These were vestiges from when Pebble and RocksDB implementations co-existed. Epic: none Release note: none
|
This change is |
RaduBerinde
approved these changes
Jun 22, 2025
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)
|
TFTR! bors r=RaduBerinde |
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the short attribute extractor in temporary engines. The short attribute extractor is only capable of parsing Cockroach MVCC keys. Additionally, rename some temp engine identifiers that needlessly were prefixed with 'Pebble'. These were vestiges from when Pebble and RocksDB implementations co-existed.
Epic: none
Release note: none