Skip to content

changelog_incremental is set as default when calling changelog from cz bump #883

Open
@LuisHenri

Description

@LuisHenri
Contributor

Description

cz bump with changelog_incremental = false on pyproject.toml doesn't have any effect when calling cz bump --changelog or cz bump with update_changelog_on_bump = true`.

Steps to reproduce

  1. Define changelog_incremental = false and update_changelog_on_bump = true
  2. Run cz bump

Current behavior

It runs as if changelog_incremental = true.

Desired behavior

Run cz ch without incremental.

Screenshots

image
https://github.com/commitizen-tools/commitizen/blob/9d0878c201c579aaf7d7c0219f19f95897bd01fc/commitizen/commands/bump.py#L272C1-L279C14

Environment

Commitizen Version: 3.10.0
Python Version: 3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Operating System: Windows

Activity

changed the title [-]Good bug title tells us about precise symptom, not about the root cause.[/-] [+]changelog_incremental is set as default when calling changelog from cz bump[/+] on Oct 11, 2023
Lee-W

Lee-W commented on Oct 17, 2023

@Lee-W
Member

Hi @LuisHenri , thanks for reporting this issue. I've verified this is indeed a valid bug.

Lee-W

Lee-W commented on Oct 17, 2023

@Lee-W
Member

We'd appreciate it if you're interested in sending us a PR. 🙂 I think this should be an easy and small one. Other than the value change, all we need is adding a few tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @Lee-W@LuisHenri

      Issue actions

        changelog_incremental is set as default when calling changelog from cz bump · Issue #883 · commitizen-tools/commitizen