Skip to content

BREAKING(cli/unstable): replace ... more content indication with up and down arrows #6699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented May 30, 2025

After trying the api, ... seems not too intuitive, nothing indicates if there is more content above.
This PR changes the more content indication ... to a arrow and additionally it indicates if moving up is possible with a arrow. It also adds indicator and visibleLines properties to promptMultipleSelect().

What country are you from?
❯ Brazil
  United States
  Japan
  ↓

...

What country are you from?
  ↑
  United States
  Japan
❯ China
  ↓

...

What country are you from?
  ↑
  China
  Canada
❯ Spain

@timreichen timreichen requested a review from kt3k as a code owner May 30, 2025 22:58
@github-actions github-actions bot added the cli label May 30, 2025
@timreichen timreichen changed the title BREAKING(cli/unstable): replace ... with up and down arrows BREAKING(cli/unstable): replace ... more content indication with up and down arrows May 30, 2025
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (2ff7074) to head (15d7e2e).

Files with missing lines Patch % Lines
cli/unstable_prompt_multiple_select.ts 95.58% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6699   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         583      583           
  Lines       42251    42321   +70     
  Branches     6653     6666   +13     
=======================================
+ Hits        39771    39837   +66     
- Misses       2431     2435    +4     
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Jun 2, 2025

Is this way of indicating 'more content' common in general? What do other tools do for this situation?

cc @WasixXD

@WasixXD
Copy link
Contributor

WasixXD commented Jun 2, 2025

Some tools just loop over (like Inquirer select) and others don't even bother, but I find the arrows a nice fit

@kt3k
Copy link
Member

kt3k commented Jun 30, 2025

I personally prefer ... for indicating 'more contents' which feels more common to me.

↑ and ↓ in this context feel confusing to me. (I don't remember the use case where ↑ and ↓ indicating 'more contents')

@timreichen
Copy link
Contributor Author

I personally prefer ... for indicating 'more contents' which feels more common to me.

↑ and ↓ in this context feel confusing to me. (I don't remember the use case where ↑ and ↓ indicating 'more contents')

The arrows have the additional benefit of not just indicating more contents, but also the location.
... seems fine until one scrolls and content gets out of bounds above, which is not very intuitive to me.

@kt3k
Copy link
Member

kt3k commented Jul 2, 2025

The arrows have the additional benefit of not just indicating more contents, but also the location. ... seems fine until one scrolls and content gets out of bounds above, which is not very intuitive to me.

I think that situation can be covered by showing ... above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants