-
Notifications
You must be signed in to change notification settings - Fork 657
BREAKING(cli/unstable): replace ...
more content indication with up and down arrows
#6699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
BREAKING(cli/unstable): replace ...
more content indication with up and down arrows
#6699
Conversation
...
with up and down arrows...
more content indication with up and down arrows
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6699 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 583 583
Lines 42251 42321 +70
Branches 6653 6666 +13
=======================================
+ Hits 39771 39837 +66
- Misses 2431 2435 +4
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is this way of indicating 'more content' common in general? What do other tools do for this situation? cc @WasixXD |
Some tools just loop over (like Inquirer select) and others don't even bother, but I find the arrows a nice fit |
I personally prefer ↑ and ↓ in this context feel confusing to me. (I don't remember the use case where ↑ and ↓ indicating 'more contents') |
The arrows have the additional benefit of not just indicating |
I think that situation can be covered by showing |
After trying the api,
...
seems not too intuitive, nothing indicates if there is more content above.This PR changes the more content indication
...
to a↓
arrow and additionally it indicates if moving up is possible with a↑
arrow. It also addsindicator
andvisibleLines
properties topromptMultipleSelect()
.What country are you from? ❯ Brazil United States Japan ↓
...
What country are you from? ↑ United States Japan ❯ China ↓
...
What country are you from? ↑ China Canada ❯ Spain