Skip to content

Commit 14ee753

Browse files
authored
Remove panning from undo stack (#483)
1 parent f85adf0 commit 14ee753

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

src/components/EditorCanvas/Canvas.jsx

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,13 @@ import {
2323
useAreas,
2424
useNotes,
2525
useLayout,
26+
useSaveState,
2627
} from "../../hooks";
2728
import { useTranslation } from "react-i18next";
2829
import { useEventListener } from "usehooks-ts";
2930
import { areFieldsCompatible } from "../../utils/utils";
3031
import { getRectFromEndpoints, isInsideRect } from "../../utils/rect";
31-
import { noteWidth } from "../../data/constants";
32+
import { noteWidth, State } from "../../data/constants";
3233

3334
export default function Canvas() {
3435
const { t } = useTranslation();
@@ -42,6 +43,7 @@ export default function Canvas() {
4243

4344
const { tables, updateTable, relationships, addRelationship, database } =
4445
useDiagram();
46+
const { setSaveState } = useSaveState();
4547
const { areas, updateArea } = useAreas();
4648
const { notes, updateNote } = useNotes();
4749
const { layout } = useLayout();
@@ -540,19 +542,7 @@ export default function Canvas() {
540542
}
541543

542544
if (panning.isPanning && didPan()) {
543-
setUndoStack((prev) => [
544-
...prev,
545-
{
546-
action: Action.PAN,
547-
undo: { x: panning.panStart.x, y: panning.panStart.y },
548-
redo: transform.pan,
549-
message: t("move_element", {
550-
coords: `(${transform?.pan.x}, ${transform?.pan.y})`,
551-
name: "diagram",
552-
}),
553-
},
554-
]);
555-
setRedoStack([]);
545+
setSaveState(State.SAVING);
556546
setSelectedElement((prev) => ({
557547
...prev,
558548
element: ObjectType.NONE,

src/components/EditorHeader/ControlPanel.jsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -297,12 +297,6 @@ export default function ControlPanel({
297297
}
298298
}
299299
setRedoStack((prev) => [...prev, a]);
300-
} else if (a.action === Action.PAN) {
301-
setTransform((prev) => ({
302-
...prev,
303-
pan: a.undo,
304-
}));
305-
setRedoStack((prev) => [...prev, a]);
306300
}
307301
};
308302

@@ -477,12 +471,6 @@ export default function ControlPanel({
477471
}
478472
}
479473
setUndoStack((prev) => [...prev, a]);
480-
} else if (a.action === Action.PAN) {
481-
setTransform((prev) => ({
482-
...prev,
483-
pan: a.redo,
484-
}));
485-
setUndoStack((prev) => [...prev, a]);
486474
}
487475
};
488476

src/data/constants.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ export const Action = {
5959
MOVE: 1,
6060
DELETE: 2,
6161
EDIT: 3,
62-
PAN: 4,
6362
};
6463

6564
export const State = {

0 commit comments

Comments
 (0)