Skip to content

[build] only include specific props into izpack installer #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2025
Merged

[build] only include specific props into izpack installer #5724

merged 2 commits into from
Jun 28, 2025

Conversation

line-o
Copy link
Member

@line-o line-o commented May 2, 2025 •
edited
Loading

forward port of #5723

@line-o line-o requested a review from a team as a code owner May 2, 2025 14:09
@line-o line-o added the security label May 2, 2025
@line-o line-o added this to v7.0.0 May 2, 2025
@duncdrum duncdrum moved this to In review in v7.0.0 May 2, 2025
dizzzz
dizzzz reviewed May 4, 2025
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a real (?) build issue?

@line-o
Copy link
Member Author

line-o commented May 14, 2025

I suspect that we listed a property that is unset.

@line-o line-o marked this pull request as draft May 14, 2025 11:27
@reinhapa
Copy link
Member

@line-o just let it run with a IzPack 7.0.0 local development version and here are the properties where is no value available:

[WARNING] Specified property: project.build.target does not exist
[WARNING] Specified property: project.build.source does not exist
[WARNING] Specified property: jdom1.version does not exist

I suggest to remove those and it should work... (NPE within IzPack will be fixed in the upcoming major release)

@line-o line-o marked this pull request as ready for review June 23, 2025 18:24
@reinhapa
Copy link
Member

@dizzzz any obligations of merging this?

@dizzzz
Copy link
Member

dizzzz commented Jun 28, 2025

Gogogo!

@dizzzz dizzzz merged commit a9ab65b into eXist-db:develop Jun 28, 2025
10 of 17 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in v7.0.0 Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz approved these changes

@duncdrum duncdrum duncdrum approved these changes

Assignees

@reinhapa reinhapa

Labels
security
Projects
v7.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@line-o @reinhapa @dizzzz @duncdrum