Fix handling of uint64_t in Embind #24285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test expectations were incorrect: it mixed up int64/uint64 and was returning negative number in uint64 function and expecting the negative sign to be preserved. Now that behaviour of uint64 is fixed, this expectation doesn't hold. Additionally, it was relying on the `n` suffix being printed by `console.log`, which is not portable and is not printed in e.g. latest Node.js. The correct test is now better served by test_i64_binding which correctly checks the type limits, signs, and will also run across more engines.
sbc100
reviewed
May 8, 2025
RReverser
commented
May 8, 2025
Not sure why tests pass fine for me locally but not on CI, but it has to be related to RTTI checks...
brendandahl
reviewed
May 8, 2025
sbc100
reviewed
May 8, 2025
|
Will fix test failures a bit later. |
brendandahl
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix,
uint64_twould be returned as a signed integer from Embind (e.g. if you returnUINT64_MAX, it gets returned as-1).I fixed that behaviour so that unsigned integers are correctly "fixed up" like they already are for
uint32_t, and added tests for 64-bit integer limits totest_i64_binding.In the process I had to also delete the invalid test
other.test_embind_long_long- it had incorrect expectations (see commit message for more details) and is now superseded by the correct test mentioned above.