Skip to content

Don't include alpha versions in tutorial bundle #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

Don't include alpha versions in tutorial bundle #7067

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d921f2f
Don't include alpha versions in tutorial bundle
emilypgoogle Jun 23, 2025
636190a
Format
emilypgoogle Jun 23, 2025
e670a31
Add logging for skipped libraries
emilypgoogle Jun 23, 2025
4df7ba7
Merge branch 'main' into ep/tutorial-alpha-versions
emilypgoogle Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions plugins/src/main/java/com/google/firebase/gradle/bomgenerator/GenerateTutorialBundleTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,13 @@ abstract class GenerateTutorialBundleTask : DefaultTask() {
private fun artifactVariableString(fullArtifactName: String): String {
val (name, alias, extra) = mappings[fullArtifactName]!!

return multiLine(
"<!-- $name -->",
"<!ENTITY $alias \"$fullArtifactName:${versionString(fullArtifactName)}\">",
extra,
)
val version = versionString(fullArtifactName)
if (version.lowercase().contains("-alpha")) {
logger.info("Ignoring alpha version of $fullArtifactName")
return "" // Alpha versions should not be included in the tutorial bundle
}

return multiLine("<!-- $name -->", "<!ENTITY $alias \"$fullArtifactName:${version}\">", extra)
}

companion object {
Expand Down
Loading