-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add support for R-GCIP tenant configuration #14979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
FirebaseAuth/Sources/Swift/Backend/AuthRequestConfiguration.swift
Outdated
Show resolved
Hide resolved
… tenant properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one code suggestion above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from one comment.
Description
This PR introduces support for Regional GCIP (R-GCIP) within the Firebase Auth iOS SDK. Developers can now initialize an
Auth
instance tied to a specific tenant ID and location.The key changes are:
TenantConfig
Struct: ASendable
structTenantConfig
has been added to hold thetenantId
andlocation
(defaulting to "prod-global").Auth
Factory Method: A new static methodAuth.auth(app: FirebaseApp, tenantConfig: TenantConfig)
allows initialization with R-GCIP parameters.AuthRequestConfiguration
: The internalAuthRequestConfiguration
class now includeslocation
andtenantId
properties, populated during initialization if aTenantConfig
is provided.These changes enable applications to work with regionalized Firebase Authentication backends.
Changelog
TenantConfig
and a newAuth
initializer to specify tenant ID and location.