Add DeepGEMM kernels #1209
Add DeepGEMM kernels #1209
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates the DeepGEMM library to introduce highly optimized grouped General Matrix Multiply (GEMM) kernels, specifically for FP8 (8-bit floating point) operations. This enhancement aims to improve the performance of matrix multiplication operations crucial for deep learning models by leveraging specialized hardware acceleration provided by DeepGEMM.
Highlights
- DeepGEMM Integration: The DeepGEMM library has been added as a Git submodule, ensuring its inclusion and version control within the project.
- New Grouped FP8 GEMM API: A new Python function,
group_deepgemm_fp8_nt_groupwise, has been introduced inflashinfer/gemm.pyto expose the DeepGEMM grouped FP8 GEMM functionality to users. - Comprehensive Testing: A dedicated test suite,
test_fp8_groupwise_group_deepgemm, has been added to thoroughly validate the correctness and functionality of the new DeepGEMM grouped GEMM kernels across various input dimensions and group sizes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| @@ -0,0 +1,430 @@ | |||
| """ | |||
There was a problem hiding this comment.
Keep the original license first.
Also, the naming convention "m_" do not align with flashinfer's, we can just call it "grouped_gemm".
📌 Description
Add DeepGEMM grouped GeMM kernels.
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes