Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
Cargo.lock
to the set of tracked files.The benefits of doing this are that a) changes to transitive dependencies like in #1756 become obvious, put gentle backpressure on compile time/version multiplicity and b) all contributors are on a single source of truth.
The only downside to this change from experience is that merge conflicts with
Cargo.lock
can be quite bad and require some knowledge to resolve. Usually, when rebasingA
ontomain
the most likely thing one wants to do is retain the version ofCargo.lock
frommain
, resolve the conflicts inCargo.toml
and build the project to letcargo
figure out the new patch versions, then commit the newly generatedCargo.lock
.