Skip to content

Maybe the vocab_size can be duplicated to the mainconfig for PEFT to pick up #38017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lancercat opened this issue May 8, 2025 · 1 comment

Comments

@lancercat
Copy link

self.vision_config = vision_config

        self.vocab_size=self.text_config.vocab_size;

Due to the following check in peft

https://github.com/huggingface/peft/blob/6c489499300c652a4990cfbcc18539417e73c262/src/peft/utils/save_and_load.py#L249

@zucchini-nlp
Copy link
Member

zucchini-nlp commented May 8, 2025

cc @BenjaminBossan , i think we should check for config.get_text_config()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants