Skip to content

feat: Add encode, patch_token to RagTokenizer (fixes #35532) #37967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

demoncoder-crypto
Copy link

Addresses #35532. Please do let me know if the implementation is correct

Copy link
Contributor

github-actions bot commented May 5, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft May 5, 2025 23:11
@Rocketknight1
Copy link
Member

cc @ArthurZucker @itazap

@itazap
Copy link
Collaborator

itazap commented May 7, 2025

hello @demoncoder-crypto 🤗 Thanks for the proposal! Could you share more about the use cases or scenarios where this patch_token would be particularly beneficial for RAG models, as opposed to existing token like [SEP]? I haven't seen as many requests for a patch_token so just curious !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants