update seed_worker to set seed based on worker_id and rank #37980
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
cc @SunMarc |
…sformers into shiyu/seed_depend_on_rank
|
Test added |
|
Hi @SunMarc, there are still 2 workflows pending, is it expected? Any additional actions needed on my side? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| training_args.max_steps = 10 | ||
| # dataloader_num_workers must be > 0 to enable worker_init_fn | ||
| training_args.dataloader_num_workers = 2 |
There was a problem hiding this comment.
minor nit, please set the output_dir to self.get_auto_remove_tmp_dir() so that we don't store the results
There was a problem hiding this comment.
Done. I put it in test_trainer as args
…sformers into shiyu/seed_depend_on_rank
…ce#37980) * update seed_worker to set seed based on worker_id and rank * test case * set output_dir as remove tmp dir
What does this PR do?
Fixes #37932
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.