-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Adds use_repr to model_addition_debugger_context #37984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @RyanMullins , thank you! I left a minor comment, and something valuable would be to update model_debugging_utils.md
with the new option (with the large output size disclaimer)
Hey @RyanMullins - this looks good, do you mind running |
Was preparing for and at Google IO today. Will update the PR and send it your way tomorrow. |
1891b39
to
4c06540
Compare
4c06540
to
079c588
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Adds a
use_repr: bool
option tomodel_addition_debugger_context
to support saving full tensors to disk instead ofrepr()
-ized versions in the JSON file.Fixes #37983
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@molbap @ArthurZucker