-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[Temporary] Log some information in some pytest/pluggy internal places #37996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
0f5a40d
to
cb5d1cd
Compare
@@ -110,6 +110,7 @@ def __post_init__(self): | |||
print(f"Using {self.docker_image} docker image") | |||
if self.install_steps is None: | |||
self.install_steps = ["uv venv && uv pip install ."] | |||
self.install_steps.append("uv venv && uv pip install git+https://github.com/ydshieh/pytest.git@8.3.5-ydshieh git+https://github.com/ydshieh/pluggy.git@1.5.0-ydshieh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just my own forks for these 2 libraries with some more information printed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe thanks for continuing the investigation!
huggingface#37996) log pytest info Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
We get
from time to time. It's very unclear how could this happen. It might be pytest, pytest's plugin, our code, or even the
tee
command.This time, let's monitor some progresses in pytest and see if we can get more information when this happens again.