Skip to content

[Temporary] Log some information in some pytest/pluggy internal places #37996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 7, 2025

What does this PR do?

We get

Too long with no output (exceeded 10m0s): context deadline exceeded

from time to time. It's very unclear how could this happen. It might be pytest, pytest's plugin, our code, or even the tee command.

This time, let's monitor some progresses in pytest and see if we can get more information when this happens again.

Copy link
Contributor

github-actions bot commented May 7, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft May 7, 2025 10:12
@ydshieh ydshieh marked this pull request as ready for review May 7, 2025 10:13
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh force-pushed the disable_vvv branch 2 times, most recently from 0f5a40d to cb5d1cd Compare May 8, 2025 10:00
@ydshieh ydshieh changed the title [don't merge yet] disable vvv Log some information in some pytest/pluggy internal places May 8, 2025
@ydshieh ydshieh changed the title Log some information in some pytest/pluggy internal places [Temporary] Log some information in some pytest/pluggy internal places May 8, 2025
@@ -110,6 +110,7 @@ def __post_init__(self):
print(f"Using {self.docker_image} docker image")
if self.install_steps is None:
self.install_steps = ["uv venv && uv pip install ."]
self.install_steps.append("uv venv && uv pip install git+https://github.com/ydshieh/pytest.git@8.3.5-ydshieh git+https://github.com/ydshieh/pluggy.git@1.5.0-ydshieh")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just my own forks for these 2 libraries with some more information printed.

@ydshieh ydshieh requested a review from Cyrilvallez May 8, 2025 10:23
Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe thanks for continuing the investigation!

@ydshieh ydshieh merged commit 66e696e into main May 9, 2025
21 checks passed
@ydshieh ydshieh deleted the disable_vvv branch May 9, 2025 09:06
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
huggingface#37996)

log pytest info

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants