feat!: change arguments default and order for graph_from_lcf()
#1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I was in a really destructive mode. 😅 |
maelle
commented
Jun 10, 2025
| #' g2 <- make_graph("Franklin") | ||
| #' isomorphic(g1, g2) | ||
| #' @export | ||
| #' @cdocs igraph_lcf_vector | ||
| graph_from_lcf <- lcf_vector_impl | ||
| graph_from_lcf <- function( |
There was a problem hiding this comment.
the argument order changed. how bad is that? we had no test for the function 🤪
Once we agree on the changes I'll remove formatting changes since those will be brought in by #1869 anyway.
maelle
commented
Jun 10, 2025
| @@ -404,3 +594,9 @@ test_that("graph is updated if in LHS", { | |||
| E(g)[1:5]$weight <- 0 | |||
| expect_equal(E(g)$weight, c(rep(0, 5), 6:10)) | |||
| }) | |||
|
|
|||
| test_that("graph_from_lcf() works", { | |||
|
I think I am fine with the change. Note #1869 is merged now I hope this doesnt cause too much trouble here |
schochastics
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1858