Work correctly with authentication that is case-sensitive on username (fix #1593) #1598
+10
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
changed the title
|
Mark this ready for review and I'll approve it |
|
@gjsjohnmurray Just to confirm, this is just a revert of my previous change since you modified the Server Manager instead? I will do the same thing for Language Server and will open a PR to prepare this extension for release. I think we should do all three on Monday. |
|
Correct. It ended up as 3 commits. First reverted your change. Second adopted my initial change in SM. And when that SM change got fixed I reverted the second commit in a third. |
|
Thanks for confirming. I will make sure the Language Server change gets reverted as well and that this doesn't show up in either CHANGELOG. |
isc-bsaviano
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1593, reverting the previous unsuccessful attempt and instead leveraging #281