Skip to content

FortiOS: support for netlab_vdom to enable multi-vdom mode #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

sdargoeuves
Copy link
Contributor

@sdargoeuves sdargoeuves commented Jun 16, 2025

Enable "split-task" configuration for FortiOS, to use an administrative VDOM (equivalent to a management VRF) and a separate traffic VDOM.

@sdargoeuves
Copy link
Contributor Author

Related to this discussion

@ipspace ipspace requested a review from ssasso June 16, 2025 13:48
@ipspace
Copy link
Owner

ipspace commented Jun 16, 2025

@ssasso -- I don't have a working FortiOS VM, so it's all up to you (no pressure ;)

Also, someone needs to write a decent commit message when merging.

@sdargoeuves
Copy link
Contributor Author

sdargoeuves commented Jun 16, 2025

@ssasso I've just seen the zone-based firewall plugin, unless we can find a way to specify vdom in the topology file instead of netlab_vdom, we would need to update the file netsim/extra/firewall.zonebased/deploy.fortinet.fortios.fortios.yml to use {{ netlab_vdom }} instead of {{ vdom }}.
I've just ran the topology up, and it works, I'll push the update a bit later.
I've just had an idea to potentially improve what I did, so we don't have to update the plugin, or other future code, ideally, I should make sure {{ vdom }} is going to be the traffic vdom, rather than using {{ netlab_vdom }}
I'll test my idea, and hopefully update this PR soon
I'm starting to be even more confused 😕 I'll keep as it is currently, and will push the update to the zonebased file.

@sdargoeuves sdargoeuves changed the title Forti vdom FortiOS: support for netlab_vdom to enable multi-vdom mode Jun 16, 2025
Copy link
Collaborator

@ssasso ssasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required change in wait_for

@sdargoeuves sdargoeuves requested a review from ssasso June 17, 2025 08:50
@ipspace
Copy link
Owner

ipspace commented Jun 17, 2025

@ssasso Is this ready to merge?

@ssasso
Copy link
Collaborator

ssasso commented Jun 17, 2025

@ssasso Is this ready to merge?

yes!

-- I updated the initial description of the PR, so you can use it as commit message.

@ipspace ipspace merged commit 430ba34 into ipspace:dev Jun 17, 2025
@ipspace
Copy link
Owner

ipspace commented Jun 17, 2025

-- I updated the initial description of the PR, so you can use it as commit message.

@ssasso: Thank you!

@sdargoeuves: Great job ;) Thank you!

@sdargoeuves
Copy link
Contributor Author

@ipspace @ssasso thank you for your help, it was definitely a great learning experience!
I'll be back 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants