Add ambient mode caveats #3517
Add ambient mode caveats #3517
Conversation
|
😊 Welcome @Stevenjin8! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
Stevenjin8
added
the
release-notes-none
istio-testing
added
size/S
|
@Stevenjin8: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -174,6 +174,8 @@ message DestinationRule { | |||
|
|
|||
| // One or more named sets that represent individual versions of a | |||
| // service. Traffic policies can be overridden at subset level. | |||
| // Note that subsets are not support in ambient mode. | |||
There was a problem hiding this comment.
This is not really true. Its not supported in HTTPRoute. Its supported in waypoints though
There was a problem hiding this comment.
Ok I'm hearing contrasting things. It seems to me like most if not all of VirtualService works with waypoints. it's just alpha. So depending on who you ask, it might not be "supported." Where it gets tricky is when we start mixing Istio APIs and GWAPI. Like httproute and virtual service don't work together, and DR subsets aren't compatible with httproute.
Do most fields in VirtualService do what they say they do? Are there any fields that don't work?
There was a problem hiding this comment.
Everything but sourceLabels and sourceVersion works.
Even ignoring VS, its not really that "subsets are not supported". At worst, there is no way to reference a subset in ambient. Which is maybe practically the same thing it just seems odd since you can absolutely create subsets in ambient
There was a problem hiding this comment.
@howardjohn are you saying that the following config wouldn't do anything?
apiVersion: networking.istio.io/v1
kind: VirtualService
metadata:
name: reviews
spec:
hosts:
- reviews
http:
- match:
- headers:
end-user:
exact: jason
route:
- destination:
host: reviews
subset: v2
- route:
- destination:
host: reviews
subset: v3
There was a problem hiding this comment.
also, do you mean sourceNamespace instead of sourceVersion?
There was a problem hiding this comment.
sourceNamespace yeah sorry.
And that VS is 100% fine in ambient. What I meant was "At worst [if you exclude VirtualServices due to them being alpha], there is no way to reference a subset". if you include VS, subset is perfectly fine.
No description provided.