Skip to content

feat(scope): add description #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 12, 2025
Merged

feat(scope): add description #1093

merged 12 commits into from
Jun 12, 2025

Conversation

AugustinMauroy
Copy link
Contributor

close #217

@AugustinMauroy AugustinMauroy changed the title Feat(scope): add description feat(scope): add description May 2, 2025
crowlKats
crowlKats requested changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of it being nullable, always only support a string, and check for empty string instead as the description not being set (just like we do for package description).

AugustinMauroy
AugustinMauroy commented May 3, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy commented May 3, 2025
View reviewed changes
@AugustinMauroy AugustinMauroy requested a review from crowlKats May 30, 2025 09:47
@AugustinMauroy
Copy link
Contributor Author

bump @crowlKats now it's should be good !

crowlKats
crowlKats approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crowlKats crowlKats added this pull request to the merge queue May 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 30, 2025
@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Jun 10, 2025 •
edited
Loading

@crowlKats the merge queue has not queued

@lucacasonato lucacasonato added this pull request to the merge queue Jun 12, 2025
Merged via the queue into jsr-io:main with commit dddbf78 Jun 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to add a description field to a scope
3 participants
@AugustinMauroy @crowlKats @lucacasonato