Skip to content

🚸 Improve similar names found message #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025
Merged

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jun 24, 2025

Fixes #2734

Before After
Before message After message

Zethson added 4 commits June 24, 2025 13:46
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (8265549) to head (0a47cf4).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
- Coverage   91.84%   91.30%   -0.55%     
==========================================
  Files          69       67       -2     
  Lines       10807     9373    -1434     
==========================================
- Hits         9926     8558    -1368     
+ Misses        881      815      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Deployment URL: https://2a8fde8a.lamindb.pages.dev

@Zethson Zethson marked this pull request as ready for review June 24, 2025 12:33
@Zethson Zethson requested a review from sunnyosun June 24, 2025 12:34
@Zethson Zethson merged commit 63843eb into main Jun 24, 2025
17 of 18 checks passed
@Zethson Zethson deleted the feature/improve_similar_name branch June 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚸 Also print the record name when search names
2 participants