Skip to content

Commit c348e5b

Browse files
committed
Fix Atom feed related bugs
1 parent bedcd39 commit c348e5b

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

logviewer/app.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ def path(self):
148148
def exists(self):
149149
return os.path.isfile(self.path)
150150

151-
def url(self, recent=None):
152-
return url_for('log', channel=self.name, date=self.date, recent=recent)
151+
def url(self, recent=None, **kwargs):
152+
return url_for('log', channel=self.name, date=self.date, recent=recent, **kwargs)
153153

154154
def get_messages(self, start=None):
155155
if not self.exists:
@@ -345,14 +345,18 @@ def atom(channel):
345345
# TODO: auth
346346
# TODO: omit last group
347347
if channel is None:
348-
return redirect(url_for('atom', channel=get_default_channel()['name']))
348+
return redirect(url_for('atom', channel=get_default_channel()['name'][1:]))
349349
channel = verify_channel(channel)
350350
log = Log.today(channel)
351351
if not log.exists:
352352
flask.abort(404)
353353
messages = group_messages(log.get_messages(), app.config['GROUP_THRES'])
354354
messages = reversed(list(messages))
355-
return render_template('atom_feed.xml', log=log, messages=messages)
355+
return render_template('atom_feed.xml',
356+
log=log,
357+
messages=messages,
358+
channel=channel,
359+
)
356360

357361

358362
@app.route('/search')

logviewer/templates/atom_feed.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@
77
{% if loop.first %}
88
<updated>{{ group[-1].time.isoformat() }}</updated>
99
{% endif %}
10+
{% set log_url = log.url(_external=True) %}
1011
<entry>
1112
<title>{{ log.date }} #{{ loop.length - loop.index0 }}</title>
12-
<link href="{{ url_for('log', date=log.date, _external=True) }}#line{{ group[0].no }}" />
13+
<link href="{{ log_url }}#line{{ group[0].no }}" />
1314
<updated>{{ group[-1].time.isoformat() }}</updated>
1415
<content type="xhtml">
1516
<table xmlns="http://www.w3.org/1999/xhtml">
16-
{{ message_rows(group) }}
17+
{{ message_rows(group, log_url) }}
1718
</table>
1819
</content>
1920
</entry>

0 commit comments

Comments
 (0)