Skip to content

[libc++][test] flat_set std test uses EmplaceUnsafeContainer which is non-standard #140448

Closed
@AlexGuteniev

Description

@AlexGuteniev

EmplaceUnsafeContainer is used in tests for flat_set and flat_map to test the ability to have basic exception guarantee when underlying container throws on insert / emplace of a single element.

struct EmplaceUnsafeContainer : std::vector<T> {

Per [container.reqmts]/66, a sequence container should provide strong exception guarantee in this case.

So supporting underlying containers that don't provide that is nonstandard extension, and should be tested in libcxx test suite instead.

Metadata

Metadata

Assignees

Labels

libc++libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.questionA question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!test-suite

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions