Skip to content

[Options] Add same-address constraint to the description of '-m[no]ld-seq-sa' #141192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

Ami-zhang
Copy link
Contributor

No description provided.

@Ami-zhang Ami-zhang requested review from wangleiat and SixWeining May 23, 2025 02:29
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:loongarch labels May 23, 2025
@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-backend-loongarch

@llvm/pr-subscribers-clang

Author: None (Ami-zhang)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141192.diff

2 Files Affected:

  • (modified) clang/include/clang/Driver/Options.td (+2-2)
  • (modified) llvm/lib/Target/LoongArch/LoongArch.td (+1-1)
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 22261621df092..6226444af2d9a 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -5526,9 +5526,9 @@ def mlamcas : Flag<["-"], "mlamcas">, Group<m_loongarch_Features_Group>,
 def mno_lamcas : Flag<["-"], "mno-lamcas">, Group<m_loongarch_Features_Group>,
   HelpText<"Disable amcas[_db].{b/h/w/d}">;
 def mld_seq_sa : Flag<["-"], "mld-seq-sa">, Group<m_loongarch_Features_Group>,
-  HelpText<"Do not generate load-load barrier instructions (dbar 0x700)">;
+  HelpText<"Do not generate same-address load-load barrier instructions (dbar 0x700)">;
 def mno_ld_seq_sa : Flag<["-"], "mno-ld-seq-sa">, Group<m_loongarch_Features_Group>,
-  HelpText<"Generate load-load barrier instructions (dbar 0x700)">;
+  HelpText<"Generate same-address load-load barrier instructions (dbar 0x700)">;
 def mdiv32 : Flag<["-"], "mdiv32">, Group<m_loongarch_Features_Group>,
   HelpText<"Use div.w[u] and mod.w[u] instructions with input not sign-extended.">;
 def mno_div32 : Flag<["-"], "mno-div32">, Group<m_loongarch_Features_Group>,
diff --git a/llvm/lib/Target/LoongArch/LoongArch.td b/llvm/lib/Target/LoongArch/LoongArch.td
index 1d3dc3342a192..e1bb265be6673 100644
--- a/llvm/lib/Target/LoongArch/LoongArch.td
+++ b/llvm/lib/Target/LoongArch/LoongArch.td
@@ -135,7 +135,7 @@ def HasLAMCAS : Predicate<"Subtarget->hasLAMCAS()">;
 
 def FeatureLD_SEQ_SA
     : SubtargetFeature<"ld-seq-sa", "HasLD_SEQ_SA", "true",
-                        "Don't use load-load barrier (dbar 0x700).">;
+                        "Don't use a same-address load-load barrier (dbar 0x700).">;
 def HasLD_SEQ_SA : Predicate<"Subtarget->hasLD_SEQ_SA()">;
 
 // Assume div.w[u] and mod.w[u] can handle inputs that are not sign-extended.

…no]ld-seq-sa'

Also, remove redundant "." in feature descriptions.
@Ami-zhang Ami-zhang merged commit 7af14e5 into llvm:main May 26, 2025
6 of 11 checks passed
@Ami-zhang Ami-zhang deleted the ld-seq-sa branch May 26, 2025 02:54
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
…no]ld-seq-sa' (llvm#141192)

Also, remove redundant "." in feature descriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:loongarch clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants