Skip to content

[lldb/cmake] Don't call llvm_process_sources #141217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

[lldb/cmake] Don't call llvm_process_sources #141217

merged 1 commit into from
May 27, 2025

Conversation

labath
Copy link
Collaborator

@labath labath commented May 23, 2025

It's already called in llvm_add_library.

It's already called in llvm_add_library.
@labath labath requested review from DavidSpickett and bulbazord May 23, 2025 09:24
@labath labath requested a review from JDevlieghere as a code owner May 23, 2025 09:24
@llvmbot llvmbot added the lldb label May 23, 2025
@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-lldb

Author: Pavel Labath (labath)

Changes

It's already called in llvm_add_library.


Full diff: https://github.com/llvm/llvm-project/pull/141217.diff

1 Files Affected:

  • (modified) lldb/cmake/modules/AddLLDB.cmake (+2-3)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 2956cdb7f9c8a..3a9dcb79629b4 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -45,7 +45,6 @@ function(add_lldb_library name)
     "INSTALL_PREFIX;ENTITLEMENTS"
     "EXTRA_CXXFLAGS;DEPENDS;LINK_LIBS;LINK_COMPONENTS;CLANG_LIBS"
     ${ARGN})
-  llvm_process_sources(srcs ${PARAM_UNPARSED_ARGUMENTS})
   list(APPEND LLVM_LINK_COMPONENTS ${PARAM_LINK_COMPONENTS})
 
   if(PARAM_NO_INTERNAL_DEPENDENCIES)
@@ -77,7 +76,6 @@ function(add_lldb_library name)
     list(GET split_path -1 dir)
     file(GLOB_RECURSE headers
       ../../include/lldb${dir}/*.h)
-    set(srcs ${srcs} ${headers})
   endif()
   if (PARAM_MODULE)
     set(libkind MODULE)
@@ -101,7 +99,8 @@ function(add_lldb_library name)
     set(pass_NO_INSTALL_RPATH NO_INSTALL_RPATH)
   endif()
 
-  llvm_add_library(${name} ${libkind} ${srcs}
+  llvm_add_library(${name} ${libkind} ${headers}
+    ${PARAM_UNPARSED_ARGUMENTS}
     LINK_LIBS ${PARAM_LINK_LIBS}
     DEPENDS ${PARAM_DEPENDS}
     ${pass_ENTITLEMENTS}

@labath labath merged commit e3e5bd1 into llvm:main May 27, 2025
12 checks passed
@labath labath deleted the cmake branch May 27, 2025 12:39
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
It's already called in llvm_add_library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants