[MLIR][IRDL] Added IRDL to C++ Translation #141248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hhkit/irdl-to-cpp
…-project into hhkit/irdl-to-cpp
but rather ugly c++ code because <3 lambdas
* first draft of irdl-to-cpp toolchain * basic mlir-irdl-to-cpp tool * it works!!
Co-authored-by: Fehr Mathieu <mathieu.fehr@gmail.com>
Co-authored-by: Fehr Mathieu <mathieu.fehr@gmail.com>
Moxinilian
approved these changes
May 23, 2025
Moxinilian
reviewed
May 25, 2025
mlir/tools/mlir-opt/mlir-opt.cpp
Outdated
| @@ -302,6 +304,7 @@ void registerTestPasses() { | |||
| mlir::test::registerTestVectorReductionToSPIRVDotProd(); | |||
| mlir::test::registerTestVulkanRunnerPipeline(); | |||
| mlir::test::registerTestWrittenToPass(); | |||
| mlir::test::registerTestIrdlTestDialectConversionPass(); | |||
There was a problem hiding this comment.
Could you add this in alphabetical order?
Moxinilian
reviewed
May 25, 2025
mlir/tools/mlir-opt/mlir-opt.cpp
Outdated
| @@ -331,6 +334,7 @@ int main(int argc, char **argv) { | |||
| ::test::registerTestTransformsTransformDialectExtension(registry); | |||
| ::test::registerTestTilingInterfaceTransformDialectExtension(registry); | |||
| ::test::registerTestDynDialect(registry); | |||
| ::test::registerIrdlTestDialect(registry); | |||
There was a problem hiding this comment.
While you're at it could you sort this alphabetically too if that doesn't break anything (just try it and if CI complain let's reverse)?
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
This PR introduces a new tool, mlir-irdl-to-cpp, that converts IRDL to C++ definitions. The C++ definitions allow use of the IRDL-defined dialect in MLIR C++ infrastructure, enabling the use of conversion patterns with IRDL dialects for example. This PR also adds CMake utilities to easily integrate the IRDL dialects into MLIR projects. Note that most IRDL features are not supported. In general, we are only able to define simple types and operations. - The only type constraint supported is irdl.any. - Variadic operands and results are not supported. - Verifiers for the IRDL constraints are not generated. - Attributes are not supported. --------- Co-authored-by: Théo Degioanni <theo.degioanni.llvm.deluge062@simplelogin.fr> Co-authored-by: Fehr Mathieu <mathieu.fehr@gmail.com>
This was referenced Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A re-attempt at merging IRDL-to-CPP (#133982) after a sanitizer check failed in post-merge CI (resolving #138285).
This PR introduces a new tool, mlir-irdl-to-cpp, that converts IRDL to C++ definitions.
The C++ definitions allow use of the IRDL-defined dialect in MLIR C++ infrastructure, enabling the use of conversion patterns with IRDL dialects for example. This PR also adds CMake utilities to easily integrate the IRDL dialects into MLIR projects.
Note that most IRDL features are not supported. In general, we are only able to define simple types and operations.