Skip to content

[CI][Github] Remove test naming from premerge jobs #141527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

boomanaiden154
Copy link
Contributor

This patch removes the "test only please ignore" tagline from the premerge job names. Now that we are looking to sunset the old infrastructure pretty soon and the new infrastructure is reporting errors, we want people to actually pay attention to the failures and report anything erroneous.

This patch removes the "test only please ignore" tagline from the
premerge job names. Now that we are looking to sunset the old
infrastructure pretty soon and the new infrastructure is reporting
errors, we want people to actually pay attention to the failures and
report anything erroneous.
@llvmbot
Copy link
Member

llvmbot commented May 26, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

This patch removes the "test only please ignore" tagline from the premerge job names. Now that we are looking to sunset the old infrastructure pretty soon and the new infrastructure is reporting errors, we want people to actually pay attention to the failures and report anything erroneous.


Full diff: https://github.com/llvm/llvm-project/pull/141527.diff

2 Files Affected:

  • (modified) .ci/metrics/metrics.py (+2-2)
  • (modified) .github/workflows/premerge.yaml (+2-2)
diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index 1537bad2b0e66..40d192c6def23 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -29,8 +29,8 @@
 # name.
 GITHUB_JOB_TO_TRACK = {
     "github_llvm_premerge_checks": {
-        "Build and Test Linux (Test Only - Please Ignore Results)": "premerge_linux",
-        "Build and Test Windows (Test Only - Please Ignore Results)": "premerge_windows",
+        "Build and Test Linux": "premerge_linux",
+        "Build and Test Windows": "premerge_windows",
     }
 }
 
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 3d29f220d18a8..709b6d03d94c3 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -24,7 +24,7 @@ concurrency:
 
 jobs:
   premerge-checks-linux:
-    name: Build and Test Linux (Test Only - Please Ignore Results)
+    name: Build and Test Linux
     if: >-
         github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
@@ -70,7 +70,7 @@ jobs:
           include-hidden-files: 'true'
 
   premerge-checks-windows:
-    name: Build and Test Windows (Test Only - Please Ignore Results)
+    name: Build and Test Windows
     if: >-
         github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')

@boomanaiden154 boomanaiden154 merged commit deedc8a into llvm:main May 26, 2025
10 of 14 checks passed
@boomanaiden154 boomanaiden154 deleted the rename-github-premerge-jobs-canonical branch May 26, 2025 20:19
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
This patch removes the "test only please ignore" tagline from the
premerge job names. Now that we are looking to sunset the old
infrastructure pretty soon and the new infrastructure is reporting
errors, we want people to actually pay attention to the failures and
report anything erroneous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants