-
Notifications
You must be signed in to change notification settings - Fork 14k
[SelectionDAG] Update documentation for VECTOR_[DE]INTERLEAVE nodes. NFC #141644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectionDAG] Update documentation for VECTOR_[DE]INTERLEAVE nodes. NFC #141644
Conversation
These can now support an arbitrary factor determined by the number of operands/results. Fixes llvm#141565
@llvm/pr-subscribers-llvm-selectiondag Author: Luke Lau (lukel97) ChangesThese can now support an arbitrary factor determined by the number of operands/results. Fixes #141565 Full diff: https://github.com/llvm/llvm-project/pull/141644.diff 1 Files Affected:
diff --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index 9f66402e4c820..b5752e21048d7 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -599,17 +599,25 @@ enum NodeType {
/// vector, but not the other way around.
EXTRACT_SUBVECTOR,
- /// VECTOR_DEINTERLEAVE(VEC1, VEC2) - Returns two vectors with all input and
- /// output vectors having the same type. The first output contains the even
- /// indices from CONCAT_VECTORS(VEC1, VEC2), with the second output
- /// containing the odd indices. The relative order of elements within an
- /// output match that of the concatenated input.
+ /// VECTOR_DEINTERLEAVE(VEC1, VEC2, ...) - Returns N vectors from N input
+ /// vectors, where N is the factor to deinterleave. All input and output
+ /// vectors must have the same type.
+ ///
+ /// Each output contains the deinterleaved indices for a specific field from
+ /// CONCAT_VECTORS(VEC1, VEC2, ...):
+ ///
+ /// Result[I][J] = CONCAT_VECTORS(...)[I + N * J]
VECTOR_DEINTERLEAVE,
- /// VECTOR_INTERLEAVE(VEC1, VEC2) - Returns two vectors with all input and
- /// output vectors having the same type. The first output contains the
- /// result of interleaving the low half of CONCAT_VECTORS(VEC1, VEC2), with
- /// the second output containing the result of interleaving the high half.
+ /// VECTOR_INTERLEAVE(VEC1, VEC2, ...) - Returns N vectors from N input
+ /// vectors, where N is the factor to interleave. All input and
+ /// output vectors must have the same type.
+ ///
+ /// All input vectors are interleaved into one wide vector, which is then
+ /// chunked into equal sized parts:
+ ///
+ /// Interleaved[I] = VEC(I % N)[I / N]
+ /// Result[J] = EXTRACT_SUBVECTOR(Interleaved, J * getVectorMinNumElements())
VECTOR_INTERLEAVE,
/// VECTOR_REVERSE(VECTOR) - Returns a vector, of the same type as VECTOR,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - cheers
…NFC (llvm#141644) These can now support an arbitrary factor determined by the number of operands/results. Fixes llvm#141565
These can now support an arbitrary factor determined by the number of operands/results. Fixes #141565