Skip to content

[NFC][IR2Vec]Minor comment fixes #141672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

svkeerthy
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@svkeerthy svkeerthy changed the title Minor comment fixes [IR2Vec]Minor comment fixes May 27, 2025
@svkeerthy svkeerthy changed the title [IR2Vec]Minor comment fixes [NFC][IR2Vec]Minor comment fixes May 27, 2025
@svkeerthy svkeerthy force-pushed the users/svkeerthy/05-27-minor_comment_fixes branch from 87ccc46 to c2ef401 Compare May 27, 2025 23:25
@svkeerthy svkeerthy marked this pull request as ready for review May 27, 2025 23:26
@llvmbot
Copy link
Member

llvmbot commented May 27, 2025

@llvm/pr-subscribers-llvm-analysis

Author: S. VenkataKeerthy (svkeerthy)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141672.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Analysis/IR2Vec.h (+6-13)
diff --git a/llvm/include/llvm/Analysis/IR2Vec.h b/llvm/include/llvm/Analysis/IR2Vec.h
index 31768a32060e1..3063040093402 100644
--- a/llvm/include/llvm/Analysis/IR2Vec.h
+++ b/llvm/include/llvm/Analysis/IR2Vec.h
@@ -111,18 +111,13 @@ class Embedder {
                                                     const Vocab &Vocabulary,
                                                     unsigned Dimension);
 
-  /// Returns a map containing instructions and the corresponding vector
-  /// representations for a given module corresponding to the IR2Vec
-  /// algorithm.
+  /// Returns a map containing instructions and the corresponding embeddings.
   const InstEmbeddingsMap &getInstVecMap() const { return InstVecMap; }
 
-  /// Returns a map containing basic block and the corresponding vector
-  /// representations for a given module corresponding to the IR2Vec
-  /// algorithm.
+  /// Returns a map containing basic block and the corresponding embeddings.
   const BBEmbeddingsMap &getBBVecMap() const { return BBVecMap; }
 
-  /// Returns the vector representation for a given function corresponding to
-  /// the IR2Vec algorithm.
+  /// Returns the embedding for the current function.
   const Embedding &getFunctionVector() const { return FuncVector; }
 };
 
@@ -131,15 +126,13 @@ class Embedder {
 /// representations obtained from the Vocabulary.
 class SymbolicEmbedder : public Embedder {
 private:
-  /// Utility function to compute the vector representation for a given basic
-  /// block.
+  /// Utility function to compute the embedding for a given basic block.
   Embedding computeBB2Vec(const BasicBlock &BB);
 
-  /// Utility function to compute the vector representation for a given type.
+  /// Utility function to compute the embedding for a given type.
   Embedding getTypeEmbedding(const Type *Ty) const;
 
-  /// Utility function to compute the vector representation for a given
-  /// operand.
+  /// Utility function to compute the embedding for a given operand.
   Embedding getOperandEmbedding(const Value *Op) const;
 
 public:

Copy link
Contributor Author

svkeerthy commented May 27, 2025

Merge activity

  • May 27, 11:29 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 27, 11:30 PM UTC: @svkeerthy merged this pull request with Graphite.

@svkeerthy svkeerthy merged commit e210dc8 into main May 27, 2025
9 of 13 checks passed
@svkeerthy svkeerthy deleted the users/svkeerthy/05-27-minor_comment_fixes branch May 27, 2025 23:30
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants